Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2081][STO] Introduce DatasetMemoryManager ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2112/5/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java: PS5, Line 115: : private long getTotalSize(int datasetId) { : return storageProperties.getMemoryComponentPageSize() * (long) getNumPages(datasetId); : } This is an underestimate isn't it? It should also take into account the number of memory components, yes? -- To view, visit https://asterix-gerrit.ics.uci.edu/2112 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica76b3c8eca6f7d2ad1d962fb5ef84267c258571 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
