Till Westmann has posted comments on this change. Change subject: [NO ISSUE][RT][IDX] simplify createAccessor() ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2120/1/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessContext.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessContext.java: PS1, Line 27: IIndexAccessContext I'd prefer to call this IIndexAccessorParameters as this seems to describe the purpose of the object better. A "context" seems to imply a longer lifetime and the potential sharing of the context with other object than I would expect from this parameter object. Further I think that we should not derive this from IObjectStore. There are 2 reasons for this: 1) the parameters object should be a simple container of parameters that can be read - we should not modify this object 2) It seems cleaner to add a map (if that's what we want/need when it is needed) to the object as another parameter than to "magically" inherit it from the IObjectStore. With the introduction of this parameter object into the method signatures, we should be done with the biggest change. Further extensions of this interface would only require modifications of a) the interface, b) the implementations, and c) the users that care about additional optional parameters, but all other methods/consumers would be untouched. So the addition to this interface would be in the change that requires the addition and not in this one. Thoughts? Does this make sense? -- To view, visit https://asterix-gerrit.ics.uci.edu/2120 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae015c342e830c81d666428447b595280139740e Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
