Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2153][COMP][RT] Ensure the fulltext search option is properly handled ......................................................................
Patch Set 3: (2 comments) @Dmitry: thank you for your comments. I am going to apply the changes that you proposed and upload a revised one. https://asterix-gerrit.ics.uci.edu/#/c/2116/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java: Line 108: if (fi == AlgebricksBuiltinFunctions.AND || fi == AlgebricksBuiltinFunctions.OR) { > What about other cases? nested AND/OR, ftcontains() as input to other funct Totally makes sense. I am going to apply the change that you have proposed. Thanks! Line 123: transformed = transformed || checkParameterForFuncExpr(op, funcExpr, context, fi); > 'transformed' is always 'false' at this point, so this line could be simpli Yes. Right! -- To view, visit https://asterix-gerrit.ics.uci.edu/2116 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I240fbe08891d29532c6fcd60638a3b6bbe8da771 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian2 Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
