Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][STO] Fix memory leaks in storage ......................................................................
Patch Set 10: Code-Review+2 (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2115/10/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java: PS10, Line 63: if (pageBudget == 0) { : throw new IllegalArgumentException("Page Budget Cannot be 0"); : } Move this to the first line of the constructor. PS10, Line 66: this.pageBudget = pageBudget; Actually I recall the old logic had something to do with adding an extra page to allow force operations to complete, either that or making the number of pages odd. In any case, I don't think it is needed anymore. PS10, Line 135: openFile This being called on the assumption that a file would be opened shows you how something is wrong with the API PS10, Line 191: LOGGER.log(Level.INFO, "Reclaimed pages = " + reclaimedPages); We can keep the logging but this specific log would appear out of nowhere without any context to which file was deleted or anything. -- To view, visit https://asterix-gerrit.ics.uci.edu/2115 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ae9736c9b5fdba5795245bdf835c023e3f73b15 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
