Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2154][COMP] Extensible built-in function management ......................................................................
Patch Set 3: (2 comments) @Taewoo, I added javadocs for new classes as you requested. https://asterix-gerrit.ics.uci.edu/#/c/2118/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CCExtensionManager.java: PS2, Line 76: Set<ExtensionId> extensionIds = new HashSet<>() > So this is just to check that we're not getting duplicate extensions? Yes. There used to be a field called 'extensions' which was a Map<>, but the values were not used. So I refactored it into a local Set<> https://asterix-gerrit.ics.uci.edu/#/c/2118/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: Line 885: ISerializerDeserializer<?> payloadSerde = getDataFormat().getSerdeProvider().getSerializerDeserializer(itemType); > although it's not part of this change, maybe you want to change the method Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2118 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafbf7e4e298fb7af6cb84b402cb00cfa2e90b5ce Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
