Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2152][FUN][COMP] Enable specifying computation 
location
......................................................................


Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2114/12/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feed-with-external-function/feed-with-external-function.3.update.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feed-with-external-function/feed-with-external-function.3.update.sqlpp:

PS12, Line 25: "7"
Is there a way to validate, that the job runs using this degree of parallelism?


https://asterix-gerrit.ics.uci.edu/#/c/2114/12/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS12, Line 121: Invalid computation location
Could this contain the invalid location(s)?


https://asterix-gerrit.ics.uci.edu/#/c/2114/12/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AssignPOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AssignPOperator.java:

PS12, Line 118: setLocationConstraint
Why is is ok to replace the cardinality constraint with a location constraint? 
Doesn't this invalidate the plan when a node is replaced in the cluster?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2114
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7eed5dac03c2f260507e16cf687162d65787bd1
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to