Xikui Wang has posted comments on this change. Change subject: Added parameterized procedures ......................................................................
Patch Set 9: (3 comments) Minor comments. Will +2 after tests finish. https://asterix-gerrit.ics.uci.edu/#/c/2046/9/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java: Line 177: private void addLets(SelectExpression s) { Nice!!! https://asterix-gerrit.ics.uci.edu/#/c/2046/9/asterix-bad/src/test/java/org/apache/asterix/bad/test/BADAsterixHyracksIntegrationUtil.java File asterix-bad/src/test/java/org/apache/asterix/bad/test/BADAsterixHyracksIntegrationUtil.java: Line 52: "/Users/stevenjacobs/asterix/asertixdb/asterixdb/asterix-opt/asterix-bad/src/main/resources/asterix-build-configuration.xml"); Change this. https://asterix-gerrit.ics.uci.edu/#/c/2046/9/asterix-bad/src/test/resources/runtimets/queries/channel/ten_minute_channel/ten_minute_channel.4.sleep.sqlpp File asterix-bad/src/test/resources/runtimets/queries/channel/ten_minute_channel/ten_minute_channel.4.sleep.sqlpp: Line 25: 630000 Is this because the query is evaluated at the end of the time interval? -- To view, visit https://asterix-gerrit.ics.uci.edu/2046 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I999879b1cae0de179a1d3c232fa940228979f4fe Gerrit-PatchSet: 9 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
