Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes ......................................................................
Patch Set 50: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2025/50/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS50, Line 996: for internal dataset > One "internal dataset" too many? Done https://asterix-gerrit.ics.uci.edu/#/c/2025/50/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java: PS50, Line 102: /** : * Submit merge requests for all disk components within [minID, maxID] : * of all indexes of a given dataset in the given partition : * : * @param minID : * @param maxID : * @param partition : * @param indexInfos : * @throws HyracksDataException : */ > fix the javadocs? Done https://asterix-gerrit.ics.uci.edu/#/c/2025/50/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java: PS50, Line 29: MISSING_COMPONENT_ID > Would it be correct to call this "invalid"? Or is "missing" more appropriat Missing seems to be more approapriate in this case. It mainly handles the situation where the component Id is not found from the metadata (e.g., from a legacy dataset)? Instead of returning null, we return a specify Id to represent this... -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
