Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2162][STO] Ensure backward compatibility of component id ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2147/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java: PS2, Line 48: if (idGeneratorFactory != null) { : return idGeneratorFactory.getComponentIdGenerator(ncCtx); : } else { : // used for backward compatibility : // if idGeneratorFactory is not set for legacy lsm indexes, we return a default component id generator : // which always generates the missing component id. : return new ILSMComponentIdGenerator() { : @Override : public void refresh() { : // No op : } : : @Override : public ILSMComponentId getId() { : return LSMComponentId.MISSING_COMPONENT_ID; : } : }; : } can we make idGeneratorFactory non-final, and do this in something we assign in a readObject() implementation? (i.e. first call defaultReadObject(), then do this if the idGeneratorFactory is null...) https://asterix-gerrit.ics.uci.edu/#/c/2147/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGeneratorFactory.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGeneratorFactory.java: PS2, Line 35: private static final long serialVersionUID = 1L; seems there's no usage of this class, otherwise I would ask that this serialVersionUID be initialized to it's computed version, to maintain binary compat with serialzed forms of this, so this is fine. -- To view, visit https://asterix-gerrit.ics.uci.edu/2147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie61103b640c37729d43023b92b1245b8e2f4a264 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
