Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2162][STO] Ensure backward compatibility of component id ......................................................................
Patch Set 5: > (2 comments) > > > This got tested manually against 23761dd78f01a3bff0ccd25d3ceb3602a1d2cc1c > > by starting with that commit then moving the data and trying to > > start with this commit, right? > > Oh, I haven't done this...Are you suggesting we do this using > asterix-verify-storage? This is what asterix-verify-storage should have done with the original commit but it was doing it the other way around. That ends up catching a lot of things but not everything. I'm just suggesting we do what that job does manually for this change so we're sure it does what we think it does (e.g. make storage from before this commit compatible). -- To view, visit https://asterix-gerrit.ics.uci.edu/2147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie61103b640c37729d43023b92b1245b8e2f4a264 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
