Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][TX] Rename Asterix JobId to TxnId
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2149/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java:

Line 1100:             TxnId txnId = ((JobEventListenerFactory) 
spec.getJobletEventListenerFactory()).getTxnId();
> MAJOR SonarQube violation:
Sounds a little scary ..


Line 1314:             TxnId txnId = ((JobEventListenerFactory) 
spec.getJobletEventListenerFactory()).getTxnId();
> MAJOR SonarQube violation:
here as well


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2149
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0905595a50195b83c1afae5dde88e5502ad21b9f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to