Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2162][STO] Ensure backward compatibility of component id ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2147/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java: PS6, Line 51: protected void checkAndSetIdGeneratorFactory() { > what is the motivation to add this and move readObject override to the chil If we add readObject here, when a LSMBTreeIOOperationCallbackFactory is deserialized, the readObject is never called (since it's private, and this abstract class is newly introduced?) -- To view, visit https://asterix-gerrit.ics.uci.edu/2147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie61103b640c37729d43023b92b1245b8e2f4a264 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
