Luo Chen has submitted this change and it was merged. Change subject: [ASTERIXDB-2166] Fix bulk load bloom filters for buddy btree ......................................................................
[ASTERIXDB-2166] Fix bulk load bloom filters for buddy btree - user model changes: no - storage format changes: no - interface changes: no Details: - Fix bulk loading bloom filters for buddy btrees. For these bloom filters, the deleted keys are added through the delete method, which shouldn't be ignored by the bloom filter bulk loader Change-Id: Icc7ca46c69c9102010f4b407ca0e9d96ba19289b Reviewed-on: https://asterix-gerrit.ics.uci.edu/2152 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: abdullah alamoudi <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Anon. E. Moose #1000171: No violations found abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; No violations found; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java index 0dcf349..29ca388 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java @@ -26,11 +26,11 @@ private final IIndexBulkLoader bulkLoader; + private boolean endedBloomFilterLoad = false; + public BloomFilterBulkLoader(IIndexBulkLoader bulkLoader) { this.bulkLoader = bulkLoader; } - - private boolean endedBloomFilterLoad = false; @Override public ITupleReference add(ITupleReference tuple) throws HyracksDataException { @@ -40,7 +40,8 @@ @Override public ITupleReference delete(ITupleReference tuple) throws HyracksDataException { - //Noop + // this ensure deleted keys are also added to the bulkloader + bulkLoader.add(tuple); return tuple; } -- To view, visit https://asterix-gerrit.ics.uci.edu/2152 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc7ca46c69c9102010f4b407ca0e9d96ba19289b Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
