Till Westmann has posted comments on this change. Change subject: [NO ISSUE][TX] Make TxnLogFile Close Idempotent ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2165/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: PS1, Line 582: : : Should we warn here? Or do we need to consider this a "regular case"? https://asterix-gerrit.ics.uci.edu/#/c/2165/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java: PS1, Line 150: ACIDException What happens if we stop here instead of ignoring the interrupt and continuing until we reach the flushLSN? PS1, Line 288: logFile.close() Should we set logFile to null here or do we still need it? -- To view, visit https://asterix-gerrit.ics.uci.edu/2165 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I255e4b9af0bc78298c0a25daf0b5629d413eba6a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
