Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2148][FUN] Add init parameter for external UDF ......................................................................
Patch Set 5: (4 comments) Hmm, why do the parameters need to transported to so many places. Couldn't they just be a accessed by a specific implementation of an external function? Why does the rest of AsterixDB need to know about them? https://asterix-gerrit.ics.uci.edu/#/c/2107/5/asterixdb/asterix-external-data/src/main/resources/schema/library.xsd File asterixdb/asterix-external-data/src/main/resources/schema/library.xsd: PS5, Line 33: init_parameters Why not just "parameters" or "parameter"? https://asterix-gerrit.ics.uci.edu/#/c/2107/5/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetecterFactory.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetecterFactory.java: PS5, Line 25: Detecter Detector https://asterix-gerrit.ics.uci.edu/#/c/2107/5/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetecterFunction.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetecterFunction.java: PS5, Line 30: Detecter Detector https://asterix-gerrit.ics.uci.edu/#/c/2107/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java: PS5, Line 46: initParameters This is a little confusing. Why would every function have this parameter string? It seems that it applies only to a tiny subset functions. -- To view, visit https://asterix-gerrit.ics.uci.edu/2107 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I567ce0bcac288267595b2565e53fea61e16fbd65 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
