Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2177][STO] Use Fixed Storage Root Dir Name ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2182/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: PS4, Line 51: + File.separator : + , PS4, Line 83: + File.separator : + , https://asterix-gerrit.ics.uci.edu/#/c/2182/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: PS4, Line 342: } catch (IOException e) { : throw new IllegalStateException("Failed to create storage root directory", e); : } can we move into the for loop, so that we can include the problematic root in the exception message? -- To view, visit https://asterix-gerrit.ics.uci.edu/2182 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e9772e9da10cff33f11353610788ba541a35571 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
