Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2177][STO] Use Fixed Storage Root Dir Name
......................................................................


Patch Set 5:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2182/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java:

PS4, Line 51: 
            :         return splits.toArray(
> ,
Done


PS4, Line 83: 
            :         return splits.toArray(new 
> ,
Done


https://asterix-gerrit.ics.uci.edu/#/c/2182/4/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java:

PS4, Line 342:                 throw new IllegalStateException("Failed to 
create storage root directory at " + root, e);
             :             }
             :         }
> can we move into the for loop, so that we can include the problematic root 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2182
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e9772e9da10cff33f11353610788ba541a35571
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to