Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-1972][COMP][RT][TX] index-only plan ......................................................................
Patch Set 17: (16 comments) https://asterix-gerrit.ics.uci.edu/#/c/1866/14/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 705: isIndexOnlyPlan = false; > MAJOR SonarQube violation: Done Line 754: } > BLOCKER SonarQube violation: Done Line 930: // Variables and types for the primary-index search. > MAJOR SonarQube violation: Done Line 1243: LogicalVariable replacedVar = context.newVar(); > MAJOR SonarQube violation: Done Line 1315: > MAJOR SonarQube violation: Done Line 2217: .create(ErrorCode.CANNOT_GET_FIELD_TYPE_FOR_FIELD_NAME, e, fieldName); > CRITICAL SonarQube violation: Done Line 2374: > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1866/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 737: indexSearchOp = AccessMethodUtils.resetVariableMappingInUnionOpInIndexOnlyPlan(lojMissingVarExist, > MAJOR SonarQube violation: Done Line 961: SelectOperator selectOp = null; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1866/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: Line 178: requireVerificationAfterSIdxSearch = indexOnlyPlanInfo.getThird(); > MAJOR SonarQube violation: Done Line 179: doesSIdxSearchCoverAllPredicates = indexOnlyPlanInfo.getFourth(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1866/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 174: // Gathers the variable to field-name mapping information for (unnest-map)? > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1866/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java: Line 1643 > CRITICAL SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1866/17/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java: Line 244: // System.out.println("searchPred " + searchPred + " count " + count); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1866/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentReplacementContext.java: Line 233: return null; > MAJOR SonarQube violation: Done Line 243: return null; > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1866 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5c9ab1cf2e4bedb7d8db582441919875e74d51 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
