Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][STO] Introduce Index Checkpoints
......................................................................


Patch Set 10:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2200/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IIndexCheckpointManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/IIndexCheckpointManager.java:

PS7, Line 35: code
> code
Done


PS7, Line 82: Advance 
> Advance
Done


https://asterix-gerrit.ics.uci.edu/#/c/2200/7/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java:

PS7, Line 29: "
> Add a comment why this starts with "."?
Done


https://asterix-gerrit.ics.uci.edu/#/c/2200/7/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java
File 
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java:

PS7, Line 336: erat
> If and else are the same?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2200
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib22800002bf8ea3660242e599b3f5f20678301a8
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to