Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][STO] Introduce Index Checkpoints ......................................................................
Patch Set 12: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/2200/11//COMMIT_MSG Commit Message: PS11, Line 10: > I think there are storage changes. Done https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManager.java: PS11, Line 147: > This seems to lose the root exception. Removed. PS11, Line 161: > Can this return null? No, it will either get a proper deserialized object or throw an exception. PS11, Line 165: dexCheckpoi > Would it make sense to throw IOExceptions inside the class instead of loggi Done https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManagerProvider.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/IndexCheckpointManagerProvider.java: PS11, Line 43: indexCheckpointManagerMap.putIfAbsent(ref, new IndexCheckpointManager(getIndexPath(ref))); : return indexCheckpointManagerMap.get(ref); > we are already synchronized on the indexCheckpointManagerMap. I'm using putIfAbsent. It will create it only if it isn't already there. https://asterix-gerrit.ics.uci.edu/#/c/2200/11/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBuffer.java: PS11, Line 323: } cat > Looks like we'll get an NPE here, if the thread is interrupted when waiting Done https://asterix-gerrit.ics.uci.edu/#/c/2200/11/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS11, Line 630: : : : : : : : : : : : : > can we keep the comment? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2200 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib22800002bf8ea3660242e599b3f5f20678301a8 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
