Xikui Wang has posted comments on this change. Change subject: Prevent case where drop channel hangs indefinitely ......................................................................
Patch Set 1: (1 comment) Minor suggestion. Let me know if you want +2 directly. https://asterix-gerrit.ics.uci.edu/#/c/2203/1/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java: Line 125: if (!listener.getExecutorService().awaitTermination(10, TimeUnit.SECONDS)) { You may want to put these two values into a single place so you don't need to change two times in the future. (Then it would be easier if we want to make this a tunable variable) -- To view, visit https://asterix-gerrit.ics.uci.edu/2203 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed8efea454c19b2d0b86f01b196bb361d35450f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
