Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-1723] Delete managix ......................................................................
Patch Set 21: (28 comments) Formatting issues should be resolved, I think https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java: PS19, Line 86: this.logManager = replicationEnabled ? new LogManagerWithReplication(this) : new LogManager(this); : this.recoveryManager = new RecoveryManager(this, serviceCtx); : if (this.txnProperties.isCommitProfilerEnabled()) { : ecp = new EntityCommitProfiler(this, this.txnProperties.getCommitProfilerReportInterval()); : > use ? : form for brevity? Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/FaultToleranceStrategyFactory.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/FaultToleranceStrategyFactory.java: PS19, Line 37: (!repProp.isReplicationEnabled()) { : cl > else if? Done PS19, Line 38: z = NoFaultTole > define constant in ReplicationStrategyFactory and reference? Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java: PS19, Line 56: LISTEN > add and use PUBLIC address here What if it's not the same interface, though? Isn't that something we're suppose to handle? PS19, Line 62: containsKey(repli > containsKey Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java: PS19, Line 97: System.out.println("SetUp: "); > remove if no longer applicable Done PS19, Line 103: System.out.println("TearDown"); > remove if no longer applicable Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java: PS19, Line 1: /* > what is changed here? revert? I'm not sure why it doesn't show the diff, but notice the TEST_CONFIG_FILE_NAME has changed. I think the line endings are messed up. https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java: PS19, Line 57: , > insert space Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java: PS19, Line 93: > insert space Done PS19, Line 158: > remove if no longer applicable Done PS19, Line 165: > remove if no longer applicable Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java: PS19, Line 76: MutableInt uniquePartitionId = new MutableInt > remove (no longer interesting) Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ReplicationProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ReplicationProperties.java: PS19, Line 100: licationEnabled() { : return accessor.getBoolean(Option.REPLICATION_ENABLED); : } : : private static final int REPLICATION_TIME_OUT_DEFAULT = 15; : : public ReplicationProperties(PropertiesAccessor accessor) throws HyracksDataException { : super(accessor); : } : : public int getMaxRemoteRecoveryAttempts() { : return accessor.getInt(Option.REPLICATION_MAX_REMOTE_RECOVERY_ATTEMPTS); : } : : public int getReplicationFactor() { : return accessor.getInt(Option.REPLICATION_FACTOR); : } : : public List<String> getNodeIds() { : return accessor.getNCNames(); : } : : public int getLogBufferPageSize() { : return accessor.getInt(Option.REPLICATION_LOG_BUFFER_PAGESIZE); : } : : public int getLogBufferNumOfPages() { : return accessor.getInt(Option.REPLICATION_LOG_BUFFER_NUMPAGES); : } : : public int getLogBatchSize() { : return accessor.getInt(Option.REPLICATION_LOG_BATCHSIZE); : } : : public String getNodeIpFromId(String id) { : return accessor.getNCEffectiveConfig(id).getString(NCConfig.Option.PUBLIC_ADDRESS); : } : : public String getReplicationStrategy() { : return accessor.getString(Option.REPLICATION_STRATEGY); : } : : public int getReplicationTimeOut() { : return accessor.getInt(Option.REPLICATION_TIMEOUT); : } : : public MetadataProperties getMetadataProperties() { : return new MetadataProperties(accessor); : } > move back to top of class Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: Line 65: } catch (MetadataException me) { > can we add me as a cause to the new exception? Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java: PS19, Line 157: ) > include exception Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AbstractExecutionIT.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AbstractExecutionIT.java: PS19, Line 54: = joinPath("target", "ittest"); : protected sta > joinPath Done PS19, Line 83: FileUtils.copyFile(externalTestsJar, : new File(NCServiceExecutionIT.APP_HOME + "/repo", externalTestsJar.getName())); : : NCServiceExecutionIT.setUp(); : > remove if no longer applicable Done PS19, Line 97: > remove if no longer applicable Done PS19, Line 111: outdir.delete(); : } : //AsterixLifecycleIT.tearDown(); > remove if no longer applicable Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AsterixInstallerIntegrationUtil.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AsterixInstallerIntegrationUtil.java: PS19, Line 136: : > remove if no longer applicable Done PS19, Line 152: > remove if no longer applicable Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java: PS19, Line 81: , > missing space Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/resources/ReplicationIT/cc.conf File asterixdb/asterix-server/src/test/resources/ReplicationIT/cc.conf: PS19, Line 19: txn.log.dir=../asterix-server/target/tmp/asterix_nc1/txnlog > what is the root dir here? why do we need to ../asterix-server? The root seems to be in the target of the toplevel asterixdb target dir (not the combined tlp). https://asterix-gerrit.ics.uci.edu/#/c/2155/19/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: PS19, Line 287: : : : : : : : : > why removed? This automatically restarts NCs, which makes some of the replication tests not feasible. I replaced it with an API that lets you start a node manually. https://asterix-gerrit.ics.uci.edu/#/c/2155/19/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: PS19, Line 43: .getLoopbackAddress().getHostAddr > there should be a different LISTEN and PUBLIC address for REPLICATION, and I'm not sure I follow, how are a LISTEN and PUBLIC address different? PS19, Line 258: return appArgs.toArray(new String[appArgs.size()]); : } : : public IApplicationConfig getNodeScopedAppConfig() { : return appConfig; : } : : public String getPublicAddress() { : return appConfig.getString(Option.PUBLIC_ADDRESS); : } : : public void setPublicAddress(String publicAddress) { : configManager.set(nodeId, Option.PUBLIC_ADDRESS, publicAddress); : } : : public String getNCServiceAddress() { : return appConfig.getString(Option.NCSERVICE_ADDRESS); : } : : public void setNCServiceAddress(String ncserviceAddress) { : configManager.set(nodeId, Option.NCSERVICE_ADDRESS, ncserviceAddress); : } : : public int getNCServicePort() { : return appConfig.getInt(Option.NCSERVICE_PORT); : } : : public void setNCServicePort(int ncservicePort) { : configManager.set(nodeId, Option.NCSERVICE_PORT, ncservicePort); : } : : public String getClusterAddress() { : return appConfig.getString(Option.CLUSTER_ADDRESS); : } : : public void setClusterAddress(String clusterAddress) { : configManager.set(nodeId, Option.CLUSTER_ADDRESS, clusterAddress); : } : : public int getClusterPort() { : return appConfig.getInt(Option.CLUSTER_PORT); : } : : public void setClusterPort(int clusterPort) { : configManager.set(nodeId, Option.CLUSTER_PORT, clusterPort); : } : : public String getClusterListenAddress() { : return appConfig.getString(Option.CLUSTER_LISTEN_ADDRESS); : } : : public void setClusterListenAddress(String clusterListenAddress) { : configManager.set(nodeId, Option.CLUSTER_LISTEN_ADDRESS, clusterListenAddress); : } : : public int getClusterListenPort() { : return appConfig.getInt(Option.CLUSTER_LISTEN_PORT); : } : : public void setClusterListenPort(int clusterListenPort) { : configManager.set(nodeId, Option.CLUSTER_LISTEN_PORT, clusterListenPort); : } : : public String getClusterPublicAddress() { : return appConfig.getString(Option.CLUSTER_PUBLIC_ADDRESS); : } : : public void setClusterPublicAddress(String clusterPublicAddress) { : configManager.set(nodeId, Option.CLUSTER_PUBLIC_ADDRESS, clusterPublicAddress); : } : : public int getClusterPublicPort() { : return appConfig.getInt(Option.CLUSTER_PUBLIC_PORT); : } : : public void setClusterPublicPort(int clusterPublicPort) { : configManager.set(nodeId, Option.CLUSTER_PUBLIC_PORT, clusterPublicPort); : } : : public String getNodeId() { : return appConfig.getString(Option.NODE_ID); : } : : public void setNodeId(String nodeId) { : configManager.set(nodeId, Option.NODE_ID, nodeId); : } : : public String getDataListenAddress() { : return appConfig.getString(Option.DATA_LISTEN_ADDRESS); : } : : public void setDataListenAddress(String dataListenAddress) { : configManager.set(nodeId, Option.DATA_LISTEN_ADDRESS, dataListenAddress); : } : : public int getDataListenPort() { : return appConfig.getInt(Option.DATA_LISTEN_PORT); : } : : public void setDataListenPort(int dataListenPort) { : configManager.set(nodeId, Option.DATA_LISTEN_PORT, dataListenPort); : } : : public String getDataPublicAddress() { : return appConfig.getString(Option.DATA_PUBLIC_ADDRESS); : } : : public void setDataPublicAddress(String dataPublicAddress) { : configManager.set(nodeId, Option.DATA_PUBLIC_ADDRESS, dataPublicAddress); : } : : public int getDataPublicPort() { : return appConfig.getInt(Option.DATA_PUBLIC_PORT); : } : : public void setDataPublicPort(int dataPublicPort) { : configManager.set(nodeId, Option.DATA_PUBLIC_PORT, dataPublicPort); : } : : public String getResultListenAddress() { : return appConfig.getString(Option.RESULT_LISTEN_ADDRESS); : } : : public void setResultListenAddress(String resultListenAddress) { : configManager.set(nodeId, Option.RESULT_LISTEN_ADDRESS, resultListenAddress); : } : : public int getResultListenPort() { : return appConfig.getInt(Option.RESULT_LISTEN_PORT); : } : : public void setResultListenPort(int resultListenPort) { : configManager.set(nodeId, Option.RESULT_LISTEN_PORT, resultListenPort); : } : : public String getResultPublicAddress() { : return appConfig.getString(Option.RESULT_PUBLIC_ADDRESS); : } : : public void setResultPublicAddress(String resultPublicAddress) { : configManager.set(nodeId, Option.RESULT_PUBLIC_ADDRESS, resultPublicAddress); : } : : public int getResultPublicPort() { : return appConfig.getInt(Option.RESULT_PUBLIC_PORT); : } : : public void setResultPublicPort(int resultPublicPort) { : configManager.set(nodeId, Option.RESULT_PUBLIC_PORT, resultPublicPort); : } : : public String getMessagingListenAddress() { : return appConfig.getString(Option.MESSAGING_LISTEN_ADDRESS); : } : : public void setMessagingListenAddress(String messagingListenAddress) { : configManager.set(nodeId, Option.MESSAGING_LISTEN_ADDRESS, messagingListenAddress); : } : : public int getMessagingListenPort() { : return appConfig.getInt(Option.MESSAGING_LISTEN_PORT); : } : : public void setMessagingListenPort(int messagingListenPort) { : configManager.set(nodeId, Option.MESSAGING_LISTEN_PORT, messagingListenPort); : } : : public String getMessagingPublicAddress() { : return appConfig.getString(Option.MESSAGING_PUBLIC_ADDRESS); : } : : public void setMessagingPublicAddress(String messagingPublicAddress) { : configManager.set(nodeId, Option.MESSAGING_PUBLIC_ADDRESS, messagingPublicAddress); : } : : public int getMessagingPublicPort() { : return appConfig.getInt(Option.MESSAGING_PUBLIC_PORT); : } : : public void setMessagingPublicPort(int messagingPublicPort) { : configManager.set(nodeId, Option.MESSAGING_PUBLIC_PORT, messagingPublicPort); : } : : public int getReplicationPublicPort() { : return appConfig.getInt(Option.REPLICATION_LISTEN_PORT); : } : : public int getClusterConnectRetries() { : > relocate back to top? Done https://asterix-gerrit.ics.uci.edu/#/c/2155/19/hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java File hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java: PS19, Line 44: // cList.add("-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005" > comment out Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2155 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b Gerrit-PatchSet: 21 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
