Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2194][COMP] Introduce datasource functions ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2216/6/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroducePrimaryIndexForAggregationRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroducePrimaryIndexForAggregationRule.java: Line 190: } > Could we do this tag-based instead of instanceof-based? +1. Then, it would be even neater/more logical to move this check to "findDatasetAndSecondaryPrimaryIndex()" The tag-based check is already there and we could return null if it's not an internal dataset, i.e. couldn't find dataset as the method suggests. -- To view, visit https://asterix-gerrit.ics.uci.edu/2216 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcf807ac713a21e8f4d59868525467386e801303 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
