Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-1723] Delete managix
......................................................................


Patch Set 26:

(15 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2155/26/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java:

PS26, Line 58: 
@SuppressWarnings("squid:ClassVariableVisibilityCheck,squid:AS00112")
this should be on the class, not the DEFAULT_HYRACKS_CC_CLIENT_PORT field


PS26, Line 65: //NOSONAR
can be removed if the SuppressWarnings annotation is moved to the class


PS26, Line 66:  //NOSONAR
can be removed if the SuppressWarnings annotation is moved to the class


PS26, Line 67: //NOSONAR
can be removed if the SuppressWarnings annotation is moved to the class


https://asterix-gerrit.ics.uci.edu/#/c/2155/26/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalUDFLibrarian.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalUDFLibrarian.java:

PS26, Line 41:     @SuppressWarnings("squid:AS134")
this should be on the class, not the libraryManagers field


PS26, Line 66: //NOSONAR
can be removed if the SuppressWarnings annotation is moved to the class


https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java:

PS19, Line 56: LISTEN
> What if it's not the same interface, though? Isn't that something we're sup
I don't understand.  It should be the REPLICATION_PUBLIC_ADDRESS, not the 
CLUSTER_PUBLIC_ADDRESS.


https://asterix-gerrit.ics.uci.edu/#/c/2155/26/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java
File 
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java:

PS26, Line 158:  //NOSONAR
remove


PS26, Line 159: : " + e.getMessage()
can we log the exception here, and not use e.getMessage()?


https://asterix-gerrit.ics.uci.edu/#/c/2155/26/asterixdb/asterix-server/src/main/opt/local/conf/cc.conf
File asterixdb/asterix-server/src/main/opt/local/conf/cc.conf:

PS26, Line 18: asterix_nc1
should revert to not have to update all of our docs, but that can happen 
post-merge


PS26, Line 24: asterix_nc2
should revert to not have to update all of our docs, but that can happen 
post-merge


https://asterix-gerrit.ics.uci.edu/#/c/2155/26/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AbstractExecutionIT.java
File 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AbstractExecutionIT.java:

PS26, Line 94:         //        FileUtils.copyDirectoryStructure(new 
File(FileUtil.joinPath("target", "data")),
             :         //                new 
File(NCServiceExecutionIT.ASTERIX_APP_DIR
             :         //                        + 
"/clusters/local/working_dir/target/data/csv"));
remove if n/a


https://asterix-gerrit.ics.uci.edu/#/c/2155/26/hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java
File 
hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java:

PS26, Line 27: @SuppressWarnings("squid:CommentedOutCodeLine")
let's move to the addJvmArgs method, then you can lose the NOSONAR


PS26, Line 45: //NOSONAR
remove, see above


PS26, Line 45: //
indent the // (till doesn't like it this way)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2155
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b
Gerrit-PatchSet: 26
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to