Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-1564][CONF] Consistently Use Log4j2
......................................................................


Patch Set 2: -Code-Review

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2226/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java:

PS2, Line 172: Level.getLevel(s)
should check for null return and throw IllegalArgumentException() to match 
previous behavior...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2226
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic137571292f45de1f1994c61d328b97185012197
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-HasComments: Yes

Reply via email to