Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-1564][CONF] Consistently Use Log4j2 ......................................................................
Patch Set 2: (15 comments) https://asterix-gerrit.ics.uci.edu/#/c/2226/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: Line 369: LOGGER.info("Checkpoint flush dataset {}", dsr.getDatasetID()); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java: Line 35: private static final Logger LOGGER = LogManager.getLogger(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/TwitterUtil.java: Line 51: private static final Logger LOGGER = LogManager.getLogger(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java: Line 228: LOGGER.warn("Could not delete checkpoint file at: " + checkpointFiles[i].getAbsolutePath()); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RemoveDeadNodesWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RemoveDeadNodesWork.java: Line 36: private static final Logger LOGGER = LogManager.getLogger(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java: PS2, Line 172: Level.getLevel(s) > should check for null return and throw IllegalArgumentException() to match Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java: Line 156: LOGGER.info("input: {}: {}", i, conn.getConnectorId()); > MAJOR SonarQube violation: Done Line 176: writer = enforce ? EnforceFrameWriter.enforce(writer) : writer; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java: Line 54: private static final Logger LOGGER = LogManager.getLogger(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalGroupBuildOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalGroupBuildOperatorNodePushable.java: Line 42: private static final Logger LOGGER = LogManager.getLogger(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalGroupWriteOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalGroupWriteOperatorNodePushable.java: Line 45: private static final Logger LOGGER = LogManager.getLogger(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java: Line 543: LOGGER.debug( > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractExternalSortRunMerger.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractExternalSortRunMerger.java: Line 160: LOGGER.debug("final runs: {}", stop); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java: Line 242: LOGGER.debug(() -> "Processing send of message: " + msg); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/2226/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/util/ComponentUtils.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/util/ComponentUtils.java: Line 168: LOGGER.log(Level.DEBUG, > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2226 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic137571292f45de1f1994c61d328b97185012197 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
