Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: PS2, Line 45: : private static final int DEFAULT_BLOOM_FILTER_VERSION = 0; : : private static final int BLOCKED_BLOOM_FILTER_VERSION = 1; > Hmm...I'm not using the storage version in the local resource, but just use I guess it's fine, it just seems weird to have 2 versions to me (overall storage vs. bloomfilter). I see the immediate purpose though. -- To view, visit https://asterix-gerrit.ics.uci.edu/2201 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
