Michael Blow has posted comments on this change. Change subject: [NO ISSUE][TEST] Allow Diagnostic files to be run for failing tests ......................................................................
Patch Set 8: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2230/8/asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestFileContext.java File asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestFileContext.java: Line 66: } catch (Exception e) { > +1 at least there should be a comment here- but not sure I love that we're overloading sequence to be a number or String... -- To view, visit https://asterix-gerrit.ics.uci.edu/2230 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I798726514cd46bcee04a8f290df54ae5bb4fb0a6 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
