Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][RT] Remove Invalid Clear Queued Jobs API ......................................................................
[NO ISSUE][RT] Remove Invalid Clear Queued Jobs API - user model changes: no - storage format changes: no - interface changes: yes - Remove clearJobQueue from IJobManager. Details: - The current clearJobQueue API in IJobManager does not follow the typical job lifecycle. i.e. job lifecycle listener are not notified that the jobs were canceled. Since the API is not used, this change removes it to avoid any future invalid usage. Change-Id: I1bff81fe9378f9bbc9dfb04a6a9826ee052f0965 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2237 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Till Westmann <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java 2 files changed, 0 insertions(+), 10 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java index cda3037..a9ddee3 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/IJobManager.java @@ -125,9 +125,4 @@ * @return the maximum number of jobs to queue before rejecting new jobs */ int getJobQueueCapacity(); - - /** - * Clears all queued jobs - */ - void clearJobQueue(); } diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java index ffb72c9..b728e73 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java @@ -290,11 +290,6 @@ return ccs.getCCConfig().getJobQueueCapacity(); } - @Override - public void clearJobQueue() { - jobQueue.clear(); - } - private void pickJobsToRun() throws HyracksException { List<JobRun> selectedRuns = jobQueue.pull(); for (JobRun run : selectedRuns) { -- To view, visit https://asterix-gerrit.ics.uci.edu/2237 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bff81fe9378f9bbc9dfb04a6a9826ee052f0965 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
