Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2193][SQLPP] Fix dataverse resolution in functions
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Looks good - just one comment that could be addressed before or after merging.

https://asterix-gerrit.ics.uci.edu/#/c/2236/2/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS2, Line 128: %1$s
Add quotes?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2236
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699b35fb46a739e9fdfcaf5cbfd6a4a00ce4da38
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to