Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2181][FUN] Check whether a function is usable at creation ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2242/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 1705: metadataProvider.setDefaultDataverse(activeDataverse); > Let's put this into the finally block, so the default dataverse gets restor Done https://asterix-gerrit.ics.uci.edu/#/c/2242/2/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml: Line 6386 > Some tests were deleted. Why are they no longer necessary? Are all of them These tests were for looping function dependency, which is no longer possible, since a function's dependencies must exist when it is created. The new tests replace these with more robust examples. -- To view, visit https://asterix-gerrit.ics.uci.edu/2242 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I262b8cfd29117c18f452973fed147696b83f1249 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
