Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-1952][TX][IDX] Filter logs pt.2 ......................................................................
Patch Set 23: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1857/23//COMMIT_MSG Commit Message: PS23, Line 11: no IModificationOperationCallback, ILSMIndexAccessor, and ILSMHarness are modified PS23, Line 14: - outdent? PS23, Line 18: - outdent? https://asterix-gerrit.ics.uci.edu/#/c/1857/23/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILogRecord.java: PS23, Line 75: indentation seems broken - more generally I wonder, if we should split the interface change out and merge that quickly before https://asterix-gerrit.ics.uci.edu/#/c/1857/23/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java: Line 376: remove line again? https://asterix-gerrit.ics.uci.edu/#/c/1857/23/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IModificationOperationCallback.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IModificationOperationCallback.java: PS23, Line 54: May be called This seems problematic, as it is unclear when or why this would be called. For all other methods in this interface there's a clear point in the index operation lifecycle when they will be called, leaving it to the implementer of the interface if an action is taken. -- To view, visit https://asterix-gerrit.ics.uci.edu/1857 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a Gerrit-PatchSet: 23 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
