Murtadha Hubail has submitted this change and it was merged. Change subject: [ASTERIXDB-2219][STO] Skip Empty Components Replication ......................................................................
[ASTERIXDB-2219][STO] Skip Empty Components Replication - user model changes: no - storage format changes: no - interface changes: no Details: - Skip replication for empty components on flushes and merges. Change-Id: If1453f813dafa2aa6c40039fac1d0aea2f08a4e2 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2259 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: abdullah alamoudi <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java index 15ed0ff..b2c48e1 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java @@ -342,7 +342,7 @@ // newComponent is null if the flush op. was not performed. if (!failedOperation && newComponent != null) { lsmIndex.addDiskComponent(newComponent); - if (replicationEnabled) { + if (replicationEnabled && newComponent != EmptyComponent.INSTANCE) { componentsToBeReplicated.clear(); componentsToBeReplicated.add(newComponent); triggerReplication(componentsToBeReplicated, false, opType); @@ -354,7 +354,7 @@ // newComponent is null if the merge op. was not performed. if (!failedOperation && newComponent != null) { lsmIndex.subsumeMergedComponents(newComponent, ctx.getComponentHolder()); - if (replicationEnabled) { + if (replicationEnabled && newComponent != EmptyComponent.INSTANCE) { componentsToBeReplicated.clear(); componentsToBeReplicated.add(newComponent); triggerReplication(componentsToBeReplicated, false, opType); -- To view, visit https://asterix-gerrit.ics.uci.edu/2259 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1453f813dafa2aa6c40039fac1d0aea2f08a4e2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
