Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-1464][TX] Handle Interrupts in LogManager ......................................................................
Patch Set 13: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2248/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java: PS13, Line 183: rootCause.getCause() > isn't rootCause.getCause() always either null or the same as rootCause? I looked at our implementation and yes you are right. I removed this branch PS13, Line 199: Thread.currentThread().interrupt() > this shouldn't be needed unless some parent is mishandling an InterruptedEx removed https://asterix-gerrit.ics.uci.edu/#/c/2248/13/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: PS13, Line 157: // ignore interrupt > why can't we reset the interrupted once the critical section is complete? Done https://asterix-gerrit.ics.uci.edu/#/c/2248/13/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java: Line 93: // ignore interrupt > can't we re-interrupt once we have finished this action? (appendToLogTail? Done PS13, Line 104: // ignore interrupt > can't we re-interrupt once we have finished this action? (appendToLogTail? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2248 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6936a60dc572e07f01baabc3f8af3bf88a58f661 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
