Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2204][STO] Fix the IIndexCursor interface ......................................................................
Patch Set 13: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2238/13/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java: PS13, Line 135: I think this call should be close instead of destroy. RangeCursors are re-used for each search key. So after calling destroy() at this line, we may call close() again at open() method (line 191). Right now this passes through because in BTreeRangeCursor we didn't perform any check. -- To view, visit https://asterix-gerrit.ics.uci.edu/2238 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64cf8c0a5473268bdfd71fd560ee6b3bff219ce9 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
