Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2195][REPL] Replace Static Replication ......................................................................
Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2252/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NoFaultToleranceStrategy.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NoFaultToleranceStrategy.java: PS6, Line 58: NoFaultToleranceStrategy > rename Filed ASTERIXDB-2228 to do this in a subsequent change. https://asterix-gerrit.ics.uci.edu/#/c/2252/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/replication/ReplicationStrategyFactory.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/replication/ReplicationStrategyFactory.java: PS6, Line 30: none", NoRepli > none Done https://asterix-gerrit.ics.uci.edu/#/c/2252/6/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java: PS6, Line 109: Thread. > restore old thread name on shutdown Done. I checked the thread pool, it doesn't do this automatically on returning the thread, but it provides before/after execution methods that can be overridden to things like this. Filed ASTERIXDB-2229 to track the improvement. -- To view, visit https://asterix-gerrit.ics.uci.edu/2252 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5c4b0ac199a4530c807e558c8aebb1eb1284048 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
