Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2222][UI] Move dashboard to own module ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2262/2/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: PS2, Line 22: revert https://asterix-gerrit.ics.uci.edu/#/c/2262/2/asterixdb/asterix-dashboard/pom.xml File asterixdb/asterix-dashboard/pom.xml: PS2, Line 38: <version>0.9.3-SNAPSHOT</version> ${project.version} PS2, Line 43: <version>2.10.0</version> remove PS2, Line 48: <version>4.1.6.Final</version> remove PS2, Line 53: <version>2.8.4</version> remove PS2, Line 19: <project xmlns="http://maven.apache.org/POM/4.0.0"; : xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; : xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> : <parent> : <artifactId>apache-asterixdb</artifactId> : <groupId>org.apache.asterix</groupId> : <version>0.9.3-SNAPSHOT</version> : </parent> : <modelVersion>4.0.0</modelVersion> : : <artifactId>asterix-dashboard</artifactId> : <dependencies> : <dependency> : <groupId>org.apache.hyracks</groupId> : <artifactId>hyracks-http</artifactId> : </dependency> : <dependency> : <groupId>org.apache.asterix</groupId> : <artifactId>asterix-common</artifactId> : <version>0.9.3-SNAPSHOT</version> : </dependency> : <dependency> : <groupId>org.apache.logging.log4j</groupId> : <artifactId>log4j-api</artifactId> : <version>2.10.0</version> : </dependency> : <dependency> : <groupId>io.netty</groupId> : <artifactId>netty-all</artifactId> : <version>4.1.6.Final</version> : </dependency> : <dependency> : <groupId>com.fasterxml.jackson.core</groupId> : <artifactId>jackson-databind</artifactId> : <version>2.8.4</version> : </dependency> : </dependencies> : : <build> : <plugins> : <plugin> : <groupId>org.apache.rat</groupId> : <artifactId>apache-rat-plugin</artifactId> : <executions> : <execution> : <id>default</id> : <phase>validate</phase> : <goals> : <goal>check</goal> : </goals> : <configuration> : <licenses combine.children="append"> : <license implementation="org.apache.rat.analysis.license.MITLicense" /> : </licenses> : <excludes combine.children="append"> : <exclude>src/main/resources/dashboard/static/*</exclude> : </excludes> : </configuration> : </execution> : </executions> : </plugin> : </plugins> : </build> : </project> wrong indent (4 -vs- 2) -- To view, visit https://asterix-gerrit.ics.uci.edu/2262 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b48f4747cb762b0ba7a55008bcb0a026261d23 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
