abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2149] Refactor key normalizer with longer keys ......................................................................
Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2225/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/intersect/IntersectOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/intersect/IntersectOperatorDescriptor.java: PS9, Line 334: cmp != 0) { shouldn't this have || isDecisive? https://asterix-gerrit.ics.uci.edu/#/c/2225/9/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/RunMergingFrameReader.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/RunMergingFrameReader.java: PS9, Line 175: cmp != 0 shouldn't this have || isDecisive? -- To view, visit https://asterix-gerrit.ics.uci.edu/2225 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba747285af74195ef9953ed9bf5f6f217511380 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
