Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX] Filter logs pt.2
......................................................................


Patch Set 31:

(1 comment)

A quick thought on the side-effect of this patch...
Will look into it in detail later.

https://asterix-gerrit.ics.uci.edu/#/c/1857/31//COMMIT_MSG
Commit Message:

PS31, Line 15: - Only log change when filter actually widens
Just a thought the side-effect of this patch and effectiveness of this 
optimization.
For a time-correlated filter attribute (such as created_time itself), which is 
a very common usage, basically every incoming record would widen the filter 
range.

In this case, what should we expect from the log size? The log size is nearly 
doubled than before?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to