Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2184] Add Immutable DiskBTree ......................................................................
Patch Set 16: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2193/15/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java: PS15, Line 284: @Override : public void setFileId(int fileId) { : this.fileId = fileId; : } : : @Override : public boolean isExclusiveLatchNodes() { : return exclusiveLatchNodes; : } > Why is this overridden to return null now? Previously this is also null...I moved them downward accidentally... Now they're moved back. https://asterix-gerrit.ics.uci.edu/#/c/2193/15/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeSearchCursorTest.java File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeSearchCursorTest.java: PS15, Line 132: : try { : bulkloader.add(tuple); : } catch (Exception e) { : e.printStackTrace(); : } : } : bulkloader.end(); > Why's this changed? This is changed because I want this test can be reused for disk btree test, while the latter does not support insert... -- To view, visit https://asterix-gerrit.ics.uci.edu/2193 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f2a9281478c4b8665589dc695769d0497af9961 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
