Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2184] Add Immutable DiskBTree ......................................................................
Patch Set 17: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2193/15/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeSearchCursorTest.java File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-btree-test/src/test/java/org/apache/hyracks/storage/am/btree/BTreeSearchCursorTest.java: PS15, Line 132: performSearches(keys, btree, leafFrame, interiorFrame, minSearchKey, maxSearchKey, true, false, false)); : Assert.assertTrue( : performSearches(keys, btree, leafFrame, interiorFrame, minSearchKey, maxSearchKey, true, true, false)); : : btree.deactivate(); : btree.destroy(); : } : > It should probably be forked, at least I think. Reusing code is good but th Done. Did a bit of refactoring to introduce a "insertBTree" method. DiskBTreeTest simply overrides this method to bulkload. -- To view, visit https://asterix-gerrit.ics.uci.edu/2193 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f2a9281478c4b8665589dc695769d0497af9961 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
