Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][STO] Unpin pages when interrupted during reads ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2274/3/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: PS3, Line 192: log warn https://asterix-gerrit.ics.uci.edu/#/c/2274/3/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/BufferCacheTest.java File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/java/org/apache/hyracks/storage/common/BufferCacheTest.java: PS3, Line 29: .* Welcome to IntelliJ. You need to change the config to not use * until the number of imports in the same package is > 99. Also the formatting of the whole file isn't right. You will need to import the Eclipse config file. https://asterix-gerrit.ics.uci.edu/#/c/2274/3/hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/resources/log4j2.xml File hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-common-test/src/test/resources/log4j2.xml: PS3, Line 1: <!-- : ! Licensed to the Apache Software Foundation (ASF) under one : ! or more contributor license agreements. See the NOTICE file : ! distributed with this work for additional information : ! regarding copyright ownership. The ASF licenses this file : ! to you under the Apache License, Version 2.0 (the : ! "License"); you may not use this file except in complianceo : ! with the License. You may obtain a copy of the License at : ! : ! http://www.apache.org/licenses/LICENSE-2.0 : ! : ! Unless required by applicable law or agreed to in writing, : ! software distributed under the License is distributed on an : ! "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY : ! KIND, either express or implied. See the License for the : ! specific language governing permissions and limitations : ! under the License. : !--> : <Configuration status="INFO"> : <Appenders> : <Console name="Console" target="SYSTEM_ERR"> : <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/> : </Console> : </Appenders> : <Loggers> : <Root level="INFO"> : <AppenderRef ref="Console"/> : </Root> : </Loggers> : </Configuration> > this should be located somewhere common, and configured for hyracks/algebri I submitted a patch to do this: https://asterix-gerrit.ics.uci.edu/#/c/2275/1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2274 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d1c52fcf89ed90e8ef6019cd77842dd7468df49 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
