Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2249][API] Add Max Result Reads to API ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2292/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestParameters.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IRequestParameters.java: PS2, Line 34: The {@code ResultDelivery} kind required for queries in the list of statements fixme https://asterix-gerrit.ics.uci.edu/#/c/2292/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS2, Line 134: STATEMENT("statement"), : FORMAT("format"), : CLIENT_ID("client_context_id"), : PRETTY("pretty"), : MODE("mode"), : TIMEOUT("timeout"), : PLAN_FORMAT("plan-format"), : MAX_RESULT_READS("max_result_reads"); where are these spec'd? it seems lame that we have both underscore and hyphen separated parameters. IMO, underscore is ugly. -- To view, visit https://asterix-gerrit.ics.uci.edu/2292 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86f75c791f034142c5b046445870bd91378c5b3a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
