Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/2294
to look at the new patch set (#2).
Change subject: [ASTERIXDB-2248][SQLPP] Disallow use of column aliases in
GBY/HAVING
......................................................................
[ASTERIXDB-2248][SQLPP] Disallow use of column aliases in GBY/HAVING
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Column aliases defined by SELECT clause should not be referenceable
from GROUP BY/HAVING clauses because aliases are not variables.
References from ORDER BY clause are still allowed.
Change-Id: Ieb734f87904e6bf307a04b2328a2fd109151f70f
---
M
asterixdb/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias.sqlpp
M
asterixdb/asterix-app/src/test/resources/parserts/queries_sqlpp/columnalias3.sqlpp
M
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias.ast
M
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias3.ast
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/q24a/q24a.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/q24b/q24b.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/InlineColumnAliasVisitor.java
8 files changed, 130 insertions(+), 73 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/94/2294/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/2294
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb734f87904e6bf307a04b2328a2fd109151f70f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
