Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1972][COMP][RT][TX] index-only plan ......................................................................
Patch Set 41: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1866/41/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 84: public final static String NO_INDEX_ONLY_PLAN_OPTION = "noindexonly"; I wonder why "noindexonly" option was not necessary for all existing SQLPP queries? I only saw it added to some AQL queries. Can we add a SQLPP testcase for it? Not critical, so let's do it in a follow up change. https://asterix-gerrit.ics.uci.edu/#/c/1866/41/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java: PS41, Line 435: CEIL_FLOOR Should we remove CEIL_FLOOR from here? It's not really used in ATypeHierarchy methods: applyMathFunction...(). The only usage is in AccessMethodUtils, so perhaps it could be handled there locally instead of having it here. We can do this in a follow up change though, it's not critical. -- To view, visit https://asterix-gerrit.ics.uci.edu/1866 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5c9ab1cf2e4bedb7d8db582441919875e74d51 Gerrit-PatchSet: 41 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
