Till Westmann has posted comments on this change. Change subject: Asterix-Dashboard: Patch 1 ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2320/3//COMMIT_MSG Commit Message: PS3, Line 9: The following commits from your working branch will be included: : : commit 9fd20ca231eec0e42e23fbfd11ed6753e21f51ae : Author: Emilio Coronado <[email protected]> : Date: Wed Jan 24 11:35:42 2018 +0900 As the commits will be squashed by gerrit, this information should be removed from the commit message. More generally it'd be nice to follow the guidelines for commit messages at https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting https://asterix-gerrit.ics.uci.edu/#/c/2320/3/asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/codemirror-metadata.component.ts File asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/codemirror-metadata.component.ts: PS3, Line 138: disabled Should we have an issue tracking the disabled functionality? https://asterix-gerrit.ics.uci.edu/#/c/2320/3/asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/query/metadata.component.html File asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/query/metadata.component.html: PS3, Line 43: WS https://asterix-gerrit.ics.uci.edu/#/c/2320/3/asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/query/ouput.component.ts File asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/query/ouput.component.ts: PS3, Line 92: WS https://asterix-gerrit.ics.uci.edu/#/c/2320/3/asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/shared/pipes/objectType.pipe.ts File asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/shared/pipes/objectType.pipe.ts: PS3, Line 19: WS -- To view, visit https://asterix-gerrit.ics.uci.edu/2320 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Emilio Jose Coronado Lopez <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
