Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1972][COMP][RT][TX] index-only plan ......................................................................
Patch Set 43: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1866/43/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 1059: if (dataverseName == null || datasetName == null) { Can this happen (dataverseName/datasetName is null) or it would be a bug in the code that created DataSourceScanOperator? Line 1064: if (idxUsedInUnnestMap == null) { this 'if' block is equivalent to just returning 'idxUsedInUnnestMap' https://asterix-gerrit.ics.uci.edu/#/c/1866/43/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 88: private Map<LogicalVariable, List<String>> varsTofieldNameMap = new HashMap<>(); rename to 'varsToFieldNameMap' (capital 'F'). Also rename corresponding getter method. Line 115: if (subTreeOp.getOperatorTag() == LogicalOperatorTag.LIMIT) { Previously this code was looking for (select)? <-- (assign | unnest)* <-- (datasource scan | unnest-map). Now it also allows LIMIT/ORDER BY and UNION_ALL. How would having these new operators impact the regular non-index only case? Line 133: if (subTreeOp.getOperatorTag() == LogicalOperatorTag.UNIONALL) { When would this code encounter an index-only plan? -- To view, visit https://asterix-gerrit.ics.uci.edu/1866 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5c9ab1cf2e4bedb7d8db582441919875e74d51 Gerrit-PatchSet: 43 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
