Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2244][RTM] Implement micro union-all operator ......................................................................
Patch Set 7: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2277/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractPhysicalOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractPhysicalOperator.java: PS7, Line 131: Asterix > Just remove "Asterix" here (it's part of Algebricks anyway ...). Done PS7, Line 167: Hyracks > Remove "Asterix" (and Hyracks)? Done PS7, Line 171: throw new IllegalStateException() > It seems that there is no way to leave this branch alive. Do the earlier ch I've added a message. https://asterix-gerrit.ics.uci.edu/#/c/2277/7/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/MicroUnionAllPOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/MicroUnionAllPOperator.java: PS7, Line 58: MicroUnionAllRuntimeFactory runtime = new MicroUnionAllRuntimeFactory(nInputs); : builder.contributeMicroOperator(op, runtime, recordDescriptor); > Can everything except for these lines be pulled up into AbstractUnionAllPOp Done https://asterix-gerrit.ics.uci.edu/#/c/2277/7/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/SubplanRuntimeFactory.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/SubplanRuntimeFactory.java: PS7, Line 122: IllegalStateException > Add a message? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2277 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11be926f175889978c144dd4483ec565d3d86e2d Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
