Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2299/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java: PS4, Line 399: if (replicateOperator.getOutputMaterializationFlags()[i]) { : return true; : } > I see, you need it to be outside if the previous if statement breaks. I gue Because we need to check whether this specific operator is materialized and not any output of the the replicate. Since the materlializationFlag is an array and has the same indexes as the outputs list, I need to find the index in the outputs list which belongs to this operator first. I moved this logic to the AbstractReplicateOperator. Hope it is cleaner now. -- To view, visit https://asterix-gerrit.ics.uci.edu/2299 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic715c5733621e27049677f44e1ddaa0dd2c71baf Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Shiva Jahangiri <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
