Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2337
Change subject: [ASTERIXDB-1706][RT] Ensure All Result Frames Are Read
......................................................................
[ASTERIXDB-1706][RT] Ensure All Result Frames Are Read
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Currently there is a possibility that the EOS
comes in DatasetInputChannelMonitor right after
the check for avaibale frames is performed which
will result in missing some result frames from
being read. When this happens, empty result will
be returned if no frames were read before. This
change ensures that the state between checking
the avaiable frames and the EOS is consistent.
Change-Id: I7d5a78fa20fe200cfffd21a215e052481c6d61ca
---
M
hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/37/2337/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
b/hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
index e7c9042..fa7ac0d 100644
---
a/hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
+++
b/hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
@@ -192,7 +192,9 @@
}
private boolean isPartitionReadComplete(IDatasetInputChannelMonitor
monitor) {
- return (monitor.getNFramesAvailable() <= 0) && (monitor.eosReached());
+ synchronized (monitor) {
+ return (monitor.getNFramesAvailable() <= 0) &&
(monitor.eosReached());
+ }
}
private SocketAddress getSocketAddress(DatasetDirectoryRecord addr) throws
UnknownHostException {
--
To view, visit https://asterix-gerrit.ics.uci.edu/2337
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d5a78fa20fe200cfffd21a215e052481c6d61ca
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
